NimsForest Issues

landregistry: remove HTTP POST /api/v1/lands — provisioning should only happen via NATS
proposed improvement Priority: low Project: landregistry Reporter: 21 Mar 2026 17:30

Description

The `POST /api/v1/lands` HTTP endpoint duplicates what `tap.landregistry.lands.create` already handles via Wind. No production code calls this endpoint — both real provisioning flows (self-service via nimsforestecommerce and manual via cross-forest NATS) publish to `tap.landregistry.lands.create`.

The HTTP version also includes Pantheon auth middleware that adds complexity. Removing it ensures a single entry point for land creation.

**Action:** Remove `handleCreateLand` from `internal/api/server.go` and the route registration.

Comments (1)

nebula 21 Mar 2026 17:46
Grooming: set priority to low

Nebula's reasoning: This is a clean dead-code removal — the HTTP POST endpoint is confirmed unused in production, with both real provisioning flows already going through NATS. Low priority because it's not causing bugs or blocking anyone, but it's a quick win that reduces surface area and auth complexity. This can be implemented independently of the broader HTTP-to-NATS migration decision in #58, making it a safe standalone cleanup task.